https://wiki.nixos.org/w/index.php?action=history&feed=atom&title=Talk%3ANixpkgs%2FReviewing_changes 2026-04-19T21:56:10Z Revision history for this page on the wiki MediaWiki 1.45.0 https://wiki.nixos.org/w/index.php?title=Talk:Nixpkgs/Reviewing_changes&diff=17380&oldid=prev 2024-09-13T08:34:03Z

<p><span class="autocomment">How to review sub-packages?</span></p> <table style="background-color: #fff; color: #202122;" data-mw="interface"> <col class="diff-marker" /> <col class="diff-content" /> <col class="diff-marker" /> <col class="diff-content" /> <tr class="diff-title" lang="en"> <td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td> <td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 08:34, 13 September 2024</td> </tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td> <td colspan="2" class="diff-lineno">Line 1:</td></tr> <tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== How to review sub-packages? ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== How to review sub-packages? ==</div></td></tr> <tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br></td></tr> <tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>I can use an overlay to review the entire set of python3Packages, but I'm unsure how I would test for example just [https://github.com/NixOS/nixpkgs/pull/334596/files this patch]. Simply setting &lt;code&gt;python312Packages.pymupdf = self.review.python312Packages.pymupdf;&lt;/code&gt;, for example, results in errors "<del style="font-weight: bold; text-decoration: none;">error: </del>attribute 'pip' missing" and "<del style="font-weight: bold; text-decoration: none;">error: </del>attribute 'python' missing".</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>I can use an overlay to review the entire set of python3Packages, but I'm unsure how I would test for example just [https://github.com/NixOS/nixpkgs/pull/334596/files this patch]. Simply setting &lt;code&gt;python312Packages.pymupdf = self.review.python312Packages.pymupdf;&lt;/code&gt;, for example, results in errors "attribute 'pip' missing" and "attribute 'python' missing".</div></td></tr> <tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br></td></tr> <tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>[[User:L0b0|L0b0]] ([[User talk:L0b0|talk]]) 07:50, 13 September 2024 (UTC)</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>[[User:L0b0|L0b0]] ([[User talk:L0b0|talk]]) 07:50, 13 September 2024 (UTC)</div></td></tr> <!-- diff cache key mediawiki:diff:1.41:old-17379:rev-17380:php=table --> </table>

L0b0 https://wiki.nixos.org/w/index.php?title=Talk:Nixpkgs/Reviewing_changes&diff=17379&oldid=prev 2024-09-13T08:33:37Z

<p><span class="autocomment">How to review sub-packages?</span></p> <table style="background-color: #fff; color: #202122;" data-mw="interface"> <col class="diff-marker" /> <col class="diff-content" /> <col class="diff-marker" /> <col class="diff-content" /> <tr class="diff-title" lang="en"> <td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">← Older revision</td> <td colspan="2" style="background-color: #fff; color: #202122; text-align: center;">Revision as of 08:33, 13 September 2024</td> </tr><tr><td colspan="2" class="diff-lineno" id="mw-diff-left-l1">Line 1:</td> <td colspan="2" class="diff-lineno">Line 1:</td></tr> <tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== How to review sub-packages? ==</div></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><div>== How to review sub-packages? ==</div></td></tr> <tr><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br></td><td class="diff-marker"></td><td style="background-color: #f8f9fa; color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #eaecf0; vertical-align: top; white-space: pre-wrap;"><br></td></tr> <tr><td class="diff-marker" data-marker="−"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #ffe49c; vertical-align: top; white-space: pre-wrap;"><div>I can use an overlay to review the entire set of python3Packages, but I'm unsure how I would test for example just [https://github.com/NixOS/nixpkgs/pull/334596/files this patch]. [[User:L0b0|L0b0]] ([[User talk:L0b0|talk]]) 07:50, 13 September 2024 (UTC)</div></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>I can use an overlay to review the entire set of python3Packages, but I'm unsure how I would test for example just [https://github.com/NixOS/nixpkgs/pull/334596/files this patch]. <ins style="font-weight: bold; text-decoration: none;">Simply setting &lt;code&gt;python312Packages.pymupdf = self.review.python312Packages.pymupdf;&lt;/code&gt;, for example, results in errors "error: attribute 'pip' missing" and "error: attribute 'python' missing".</ins></div></td></tr> <tr><td colspan="2" class="diff-side-deleted"></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div> </div></td></tr> <tr><td colspan="2" class="diff-side-deleted"></td><td class="diff-marker" data-marker="+"></td><td style="color: #202122; font-size: 88%; border-style: solid; border-width: 1px 1px 1px 4px; border-radius: 0.33em; border-color: #a3d3ff; vertical-align: top; white-space: pre-wrap;"><div>[[User:L0b0|L0b0]] ([[User talk:L0b0|talk]]) 07:50, 13 September 2024 (UTC)</div></td></tr> <!-- diff cache key mediawiki:diff:1.41:old-17378:rev-17379:php=table --> </table>

L0b0 https://wiki.nixos.org/w/index.php?title=Talk:Nixpkgs/Reviewing_changes&diff=17378&oldid=prev 2024-09-13T07:50:46Z

<p><span class="autocomment">How to review sub-packages?: </span> new section</p> <p><b>New page</b></p><div>== How to review sub-packages? ==<br /> <br /> I can use an overlay to review the entire set of python3Packages, but I&#039;m unsure how I would test for example just [https://github.com/NixOS/nixpkgs/pull/334596/files this patch]. [[User:L0b0|L0b0]] ([[User talk:L0b0|talk]]) 07:50, 13 September 2024 (UTC)</div>

L0b0